Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix some of the Filter issues #2183

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Oct 13, 2024

Problem

This PR attempts to address some of the issues we experience with Filter.

Solution

Fixes:

  • Ensure frequent pings are sent;
  • Turn off flaky renewal logic of missing messages on Filter;
  • others

Notes

Copy link

github-actions bot commented Oct 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 85.83 KB (+0.38% 🔺) 1.8 s (+0.38% 🔺) 1.8 s (+6.89% 🔺) 3.5 s
Waku Simple Light Node 137.62 KB (+0.38% 🔺) 2.8 s (+0.38% 🔺) 3.5 s (+119.56% 🔺) 6.3 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 803 ms (-3.53% 🔽) 1.3 s
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 353 ms (-47.23% 🔽) 800 ms
DNS discovery 72.9 KB (0%) 1.5 s (0%) 1.6 s (-17.76% 🔽) 3 s
Peer Exchange discovery 74.1 KB (0%) 1.5 s (0%) 1.2 s (+8.7% 🔺) 2.7 s
Local Peer Cache Discovery 68.03 KB (0%) 1.4 s (0%) 1.3 s (-16.53% 🔽) 2.6 s
Privacy preserving protocols 76.02 KB (0%) 1.6 s (0%) 1.7 s (-14.82% 🔽) 3.2 s
Waku Filter 80.3 KB (+0.95% 🔺) 1.7 s (+0.95% 🔺) 2.3 s (+19.34% 🔺) 3.9 s
Waku LightPush 75.03 KB (0%) 1.6 s (0%) 1.8 s (+20.59% 🔺) 3.3 s
History retrieval protocols 77.03 KB (0%) 1.6 s (0%) 1.8 s (+10.28% 🔺) 3.4 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 331 ms (-28.95% 🔽) 479 ms

@weboko weboko marked this pull request as ready for review October 15, 2024 23:12
@weboko weboko requested a review from a team as a code owner October 15, 2024 23:12
Base automatically changed from weboko/lighten-send-retry to master October 16, 2024 22:49
@weboko weboko merged commit ded994f into master Oct 16, 2024
10 of 11 checks passed
@weboko weboko deleted the weboko/reliability-filter branch October 16, 2024 23:01
@weboko weboko mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants