feat(store): allow using a specific node #2192
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Oct 29, 2024
| * List of nodes' multiaddrs as strings to use for each protocol. If not specified, random nodes will be used. | ||
| * This should be used only if you know what you are doing. | ||
| */ | ||
| nodeToUse?: { |
There was a problem hiding this comment.
can you create store field with following type:
store: Partial<StoreProtocolOptions>
and StoreProtocolOptions can have:
type StoreProtocolOptions = {
peers: [],
};example for Filter in one of open PRs - 09127df
weboko
reviewed
Oct 29, 2024
| @@ -3,6 +3,7 @@ import type { Peer, Stream } from "@libp2p/interface"; | |||
| import type { | |||
There was a problem hiding this comment.
please, let's not introduce changes into this file and instead prefer peer in store.ts with something like
const preferedPeer = this.libp2p.getConnections().find(c => c.remotePeer.toString() === preferedPeerIdStr);
const peer = preferedPeer || this.getPeer();
weboko
reviewed
Oct 29, 2024
| @@ -224,6 +232,18 @@ export class WakuNode implements IWaku { | |||
| return this.connectionManager.isConnected(); | |||
| } | |||
|
|
|||
| private async dialMultiaddr( | |||
There was a problem hiding this comment.
let's not introduce this operation and use ConnectionManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users need the ability to specify the peers used for their apps, for different protocols. Specifically for Store: https://discord.com/channels/1110799176264056863/1290694275683582085/1291644836742565929
Solution
Provides the ability to pass a specific node multiaddr while node creation to be used for Store. Falls back to random nodes if not passed.
Notes
Contribution checklist:
!in title if breaks public API;