chore: add simple Qt example that uses libwaku #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
requested review from
darshankabariya,
gabrielmer and
NagyZoltanPeter
NagyZoltanPeter
approved these changes
Feb 28, 2025
examples/qt/main_qt.cpp
Outdated
| void* userData = nullptr; | ||
|
|
||
| char jsonConfig[5000]; | ||
| snprintf(jsonConfig, 5000, "{ \ |
There was a problem hiding this comment.
nitpick, but you don't need sprintf if this is only static string...or bet you can directly use QString here.
There was a problem hiding this comment.
Thanks! Addressed in d121dd9
examples/qt/waku_handler.h
Outdated
| public: | ||
| WakuHandler() : QObject(), ctx(nullptr) {} | ||
|
|
||
| void initialize(const QString& jsonConfig, void* event_handler, void* userData) { |
There was a problem hiding this comment.
I think void* event_handler can directly be WakuCallBack type...
There was a problem hiding this comment.
Thanks! Addressed in 49b352d
gabrielmer
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple Qt example that runs libwaku.
It only contains two buttons: start node; stop node.
note: This is part of investigation where we see that Status app crashes when loading libwaku.
Issue