Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WAKU2-RLN-CONTRACT spec for mainnet deployment #30

Merged
merged 28 commits into from
Aug 20, 2024
Merged

Add WAKU2-RLN-CONTRACT spec for mainnet deployment #30

merged 28 commits into from
Aug 20, 2024

Conversation

s-tikhomirov
Copy link
Contributor

This PR adds the first version of the specification for the RLN contract for mainnet deployment.

Added functionality is mainly related to membership tiers, pricing, expiration, and deposits.

This is work in progress, certain aspects are TBD for now. Comments and suggestions welcome!

See also: a less formal Notion document (not open-access) that preceded this spec.

@s-tikhomirov s-tikhomirov marked this pull request as draft August 2, 2024 15:21
fryorcraken
fryorcraken reviewed Aug 5, 2024
View reviewed changes
Copy link

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! exciting

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
s-tikhomirov and others added 2 commits August 5, 2024 12:28
@s-tikhomirov @fryorcraken @vpavlin
Apply suggestions from code review
7ea898b 
minor fixes and suggestions

Co-authored-by: fryorcraken <[email protected]>
Co-authored-by: Vaclav Pavlin <[email protected]>
@s-tikhomirov
address some suggestions
7df465d
alrevuelta
alrevuelta reviewed Aug 5, 2024
View reviewed changes
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
jm-clius
jm-clius reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Although there are some discussions ongoing, I think this covers enough scope for a raw specification. Added some comments. Feel free to mark as ready for review once it is.

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
Ivansete-status
Ivansete-status reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that! Just added my 2c

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
@s-tikhomirov s-tikhomirov marked this pull request as ready for review August 12, 2024 17:59
Ivansete-status
Ivansete-status reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for it! Added some more comments :)

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
@s-tikhomirov @Ivansete-status
fix typo
9eab39c 
Co-authored-by: Ivan FB <[email protected]>
jm-clius
jm-clius reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but I think we're close to a mergeable raw. Thanks!

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
fryorcraken
fryorcraken reviewed Aug 15, 2024
View reviewed changes
Copy link

@fryorcraken fryorcraken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments.

Main sticky point is pricing, from the angle of cost to occupy all rate (seems too low)

jm-clius
jm-clius approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, but left some comments

standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
standards/core/rln-contract.md Outdated Show resolved Hide resolved
@s-tikhomirov s-tikhomirov merged commit 72fd533 into master Aug 20, 2024
0 of 2 checks passed
@s-tikhomirov s-tikhomirov mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status left review comments

@fryorcraken fryorcraken fryorcraken left review comments

@mart1n-xyz mart1n-xyz mart1n-xyz left review comments

@jakubgs jakubgs jakubgs left review comments

@jm-clius jm-clius jm-clius approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

@vpavlin vpavlin Awaiting requested review from vpavlin

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@s-tikhomirov @richard-ramos @jakubgs @vpavlin @alrevuelta @mart1n-xyz @jm-clius @fryorcraken @Ivansete-status