Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: waku rendezvous spec #32

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feat: waku rendezvous spec #32

merged 5 commits into from
Oct 22, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Aug 13, 2024 •
edited
Loading

New spec that try to define the usage of libp2p rendezvous in the context of waku.

WIP.

@SionoiS SionoiS self-assigned this Aug 13, 2024
@SionoiS SionoiS mentioned this pull request Sep 10, 2024
Open
@SionoiS SionoiS requested a review from jm-clius October 21, 2024 15:33
jm-clius
jm-clius approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments below recommending a more "RFC-like" use of language.

standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
standards/core/rendezvous.md Outdated Show resolved Hide resolved
@SionoiS SionoiS marked this pull request as ready for review October 22, 2024 14:50
@SionoiS SionoiS merged commit 315264c into master Oct 22, 2024
0 of 2 checks passed
@SionoiS SionoiS deleted the feat--wakurendezvous branch October 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm-clius jm-clius jm-clius approved these changes

Assignees

@SionoiS SionoiS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SionoiS @jm-clius