Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store sync spec #36

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feat: store sync spec #36

merged 5 commits into from
Oct 22, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Sep 6, 2024

New Store sync spec that tie Store Resume and Waku Sync into one strategy/best practice spec.

WIP

@SionoiS SionoiS self-assigned this Sep 6, 2024
@SionoiS
Copy link
Contributor Author

SionoiS commented Oct 21, 2024

Will require some changes when Waku sync 2.0 drops but lets merge for now.

@SionoiS SionoiS requested a review from jm-clius October 21, 2024 15:33
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added some comments below. Since this is a raw spec that will be superseded very soon, I'm happy if we merge without all of the comments addressed.

standards/core/store-sync.md Outdated Show resolved Hide resolved
standards/core/store-sync.md Outdated Show resolved Hide resolved
standards/core/store-sync.md Outdated Show resolved Hide resolved
standards/core/store-sync.md Outdated Show resolved Hide resolved
standards/core/store-sync.md Outdated Show resolved Hide resolved
standards/core/store-sync.md Show resolved Hide resolved
@SionoiS
Copy link
Contributor Author

SionoiS commented Oct 22, 2024

I added your comments to the document so that we don't lose them.

@SionoiS SionoiS marked this pull request as ready for review October 22, 2024 14:25
@SionoiS SionoiS merged commit df0aead into master Oct 22, 2024
0 of 2 checks passed
@SionoiS SionoiS deleted the feat--store-sync branch October 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants