Fix foreground service crashes when launching tts SDK > 33 #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 29, 2024 20:29
Handle foreground service for versions greater than sdk33
Added missing Semi colons 😭
Import build package
Import service info package
Strubbl
approved these changes
Mar 1, 2024
|
would it be ok, if i squash and merge? edit: at first, of course: thank you 👍 |
|
Yes of course, it only ended with this many commits as I was editing in GitHub on phone and clearly need vscodes help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for crashes when launching the tts service in SDK versions greater than 33.
Linked issue #1348