use enum for bypasstype

wallet-guard · May 3, 2024 · b1f43c6 · b1f43c6
1 parent 2cdbeb6
commit b1f43c6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/content-scripts/bypassCheck.tsx b/src/content-scripts/bypassCheck.tsx
@@ -1,5 +1,6 @@
 import Browser from 'webextension-polyfill';
 import {
+  BypassType,
   PersonalSignArgs,
   SignatureHashSignArgs,
   SignatureRequestArgs,
@@ -13,7 +14,7 @@ import { PortMessage, PortIdentifiers } from '../lib/helpers/chrome/messageHandl
 import { convertObjectValuesToString, shouldSwapPersonalSignArgs } from '../injected/injectWalletGuard';
 
 const bypassed = true;
-const bypassType = 'postMessage';
+const bypassType = BypassType.PostMessage;
 
 const sendMessageToPort = (stream: Browser.Runtime.Port, data: TransactionArgs): void => {
   const message: PortMessage = {

diff --git a/src/content-scripts/contentScripts.tsx b/src/content-scripts/contentScripts.tsx
@@ -6,7 +6,7 @@ import logger from '../lib/logger';
 import { dispatchResponse, listenToRequest, Response } from '../lib/simulation/requests';
 import type { StoredSimulation } from '../lib/simulation/storage';
 import { removeSimulation, StoredSimulationState } from '../lib/simulation/storage';
-import { TransactionArgs } from '../models/simulation/Transaction';
+import { BypassType, TransactionArgs } from '../models/simulation/Transaction';
 import { ExtensionSettings, SimulationSettings } from '../lib/settings';
 import { KNOWN_MARKETPLACES, shouldSkipBasedOnDomain } from '../lib/simulation/skip';
 import { getDomainNameFromURL } from '../lib/helpers/phishing/parseDomainHelper';
@@ -65,7 +65,7 @@ listenToRequest(async (request: TransactionArgs) => {
     }
 
     // Set the bypassType, but do not set bypassed = true because otherwise the simulation buttons will be incorrect
-    request.bypassType = 'chainId';
+    request.bypassType = BypassType.ChainId
   }
 
   let currentTab = window.location.href;

diff --git a/src/models/simulation/Transaction.ts b/src/models/simulation/Transaction.ts
@@ -76,7 +76,12 @@ interface RequestArgs {
   // Whether this request is a bypassed request.
   bypassed?: boolean;
   // The type of the attempted bypass
-  bypassType?: 'postMessage' | 'chainId';
+  bypassType?: BypassType;
+}
+
+export enum BypassType {
+  PostMessage = 'postMessage',
+  ChainId = 'chainId',
 }
 
 export type SimulationResponse =