Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom dir on fs storage #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

prakasa-tkpd
Copy link

@prakasa-tkpd prakasa-tkpd commented Jun 24, 2021

Background

Currently for fs storage type will always store profiling result to os.tmpdir(). That is might be hard for beginner developers to find where is the tmpdir in the OS. And refer to the document, we have storage.dir as target custom directory, but currently this option only support for s3. So I think we need to adding storage.dir option to support for fs storage type.

e.g:

const Inspector = require("inspector-api");

const inspector = new Inspector({
   storage: {
     type: "fs",
     dir: "./profile-results",
   },
});

Copy link

@vincentvalletvoodoo vincentvalletvoodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work done.
Could you just add a test to validate this use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants