-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
concord-server: order ui_process_card by a new order_id field #1075
concord-server: order ui_process_card by a new order_id field #1075
Conversation
oalfonso-o
commented
Feb 5, 2025
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments, otherwise LGTM.
Unfortunately it is not enough to approve the checks run -- the build still fails on retrieving the repository's Docker secret. I'll try to figure this out tomorrow.
@Schema(name = Constants.Multipart.ORDER_ID) | ||
public Integer getOrderId() { | ||
return MultipartUtils.getInt(input, Constants.Multipart.ORDER_ID); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline after the closing curly.
@@ -615,6 +615,8 @@ public static class Multipart { | |||
public static final String SYNC = "sync"; | |||
|
|||
public static final String META = "meta"; | |||
|
|||
public static final String ORDER_ID = "order_id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static final String ORDER_ID = "order_id"; | |
public static final String ORDER_ID = "orderId"; |
…esscard_add_order