Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concord-server: order ui_process_card by a new order_id field #1075

Merged
merged 14 commits into from
Feb 12, 2025

Conversation

oalfonso-o
Copy link
Contributor

@oalfonso-o oalfonso-o commented Feb 5, 2025

postgres=# select ui_process_card_id, name, order_id from ui_process_cards;
          ui_process_card_id          | name | order_id
--------------------------------------+------+----------
 00000000-0000-0000-0000-000000000111 | 4    |        4
 00000000-0000-0000-0000-000000000112 | 3    |        3
 00000000-0000-0000-0000-000000000113 | 2    |        2
 00000000-0000-0000-0000-000000000114 | 1    |        1

image

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@ibodrov ibodrov changed the title Order ui_process_card by a new order_id field concord-server: order ui_process_card by a new order_id field Feb 7, 2025
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, otherwise LGTM.

Unfortunately it is not enough to approve the checks run -- the build still fails on retrieving the repository's Docker secret. I'll try to figure this out tomorrow.

@Schema(name = Constants.Multipart.ORDER_ID)
public Integer getOrderId() {
return MultipartUtils.getInt(input, Constants.Multipart.ORDER_ID);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline after the closing curly.

@@ -615,6 +615,8 @@ public static class Multipart {
public static final String SYNC = "sync";

public static final String META = "meta";

public static final String ORDER_ID = "order_id";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String ORDER_ID = "order_id";
public static final String ORDER_ID = "orderId";

@ibodrov ibodrov merged commit be408d7 into walmartlabs:master Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants