Change a few tests that try to construct an invalid datetime in some timezones #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these tests break between 1am and 2am in countries that observe daylight savings time and move the clocks forward on the last sunday of march, for example BST. March 30th was the last sunday of march in 2014, so the clocks jumped from 1am to 2am on that date, meaning that datetimes on that date between 1am and 2am are an invalid time in those timezones. Therefore, those tests fail during that time period, every day
waltzofpearls
approved these changes
Jun 3, 2024
|
Will merge this PR since I have just fix the failed clippy check in another PR, and the failed clippy check is not caused by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests break between 1am and 2am in some timezones that observe daylight savings time, including most european timezones.
The affected timezones move forward 1 hour at 1am on the last Sunday of March. March 30th was the last Sunday of March in 2014, meaning that in the affected timezones, March 30th 2014 1:31am (for example) never happened.
This means that these 3 test cases, which all try to construct a datetime with the date of 2014/03/30 but with the current time, attempt to create an invalid date if the test is run between 1am and 2am.
This patch just changes each test to 2014/03/29, which has no weird properties (as far as I know)