Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1 d pipeline #18

Merged
merged 15 commits into from
Sep 7, 2024
Merged

1 d pipeline #18

merged 15 commits into from
Sep 7, 2024

Conversation

dzhingarska
Copy link
Collaborator

adjusting 1D pipeline to the framework

@warisa-r
Copy link
Owner

warisa-r commented Sep 5, 2024

Very nice! Could u add a test in runtests.jl for the supersonic?

warisa-r
warisa-r requested changes Sep 6, 2024
View reviewed changes
Copy link
Owner

@warisa-r warisa-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! Just one last thing: Can u use docstring to document detect for both 1D and 2D?

warisa-r
warisa-r approved these changes Sep 7, 2024
View reviewed changes
Copy link
Owner

@warisa-r warisa-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me!

@warisa-r warisa-r merged commit c04bb62 into main Sep 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warisa-r warisa-r warisa-r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzhingarska @warisa-r