feat(quickstart): override Redis dependency instead of yaml edit #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dreamy-golick-5f201e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brooksmtownsend
force-pushed
the
feat/interface-override-quickstart
branch
from
8d9044d to
0735367
Compare
ricochet
reviewed
Nov 8, 2024
ericgregory
reviewed
Nov 8, 2024
ericgregory
reviewed
Nov 8, 2024
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud! |
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/interface-override-quickstart
branch
from
0735367 to
b41951f
Compare
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Eric Gregory <[email protected]>
ricochet
reviewed
Feb 5, 2025
Signed-off-by: Eric Gregory <[email protected]>
brooksmtownsend
commented
Feb 5, 2025
Signed-off-by: Eric Gregory <[email protected]>
ericgregory
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR uses interface level overrides to override the keyvalue dependency in the quickstart.
Will depend on wash 0.38 being released, and a newer keyvalue provider version.
Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification