-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bundle install rakefile #58
Conversation
Unsupported in bundler. rubygems/rubygems#4838
Add test dependencies to gemspec
@Hywan any thoughts? |
Hello @tsmartt! Thank you for your PR, and I'm happy to learn you're using wasmer-ruby :-)! I would love to embed a shared object or even a static object with the Ruby extensions. We have this PR, #6, but it's based on Thermite, which seems abandonned. Thought? |
I'm correcting myself. With the work I did in Lines 3 to 32 in c1b554b
|
The user can still install the extension, in fact, we still do. The only change is that, when installing, all we do is call If you want to distribute prebuilt binaries, that would further simplify installation, but is a separate concern to this PR. All I cared about here was not running |
Also to run the tests, you can still run If there's no objection @Hywan perhaps we can go ahead and merge? If there's any other way I can help out, I'm happy to. |
@Hywan any update? Do you want me to do anything else for this? |
Sorry, I was in vacations, and then been under water. I'm all OK to merge this PR. Can you update the Install Section of the |
What would you like me to add? The install should still be the same, we're just fixing a bug here. |
Wonderful library. We use it for our app publishers.
This PR resolves this ticket. An install would break our build because of the call to bundle in
Rakefile
. I've added these as development dependencies and make the default task the one that builds the library. Ideally, we'd package a native gem like mentioned here, but this at least stops us from polluting the bundle namespace and breaking builds.