This repository has been archived by the owner on May 7, 2024. It is now read-only.
Make the package field optional #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in wasmer.toml, the package field will now be optional. This is to add support for unnamed packages. Unnamed packages are useful when you don't want to publish and maintain a package just for an app. In that case, you can simply associate the package with a webc hash, instead associating it with a package name/version etc.
|
⏱ Workflow Timer ⏱
🤖 Beep. Boop. I'm a bot. If you find any issues, please report them to https://github.com/Michael-F-Bryan/workflow-timer. |
maminrayej
reviewed
Mar 29, 2024
src/lib.rs
Outdated
Comment on lines
745
to
753
| if let Some(mut package) = manifest.package.clone() { | ||
| if package.readme.is_none() { | ||
| package.readme = locate_file(path, README_PATHS); | ||
| } | ||
|
|
||
| if manifest.package.license_file.is_none() { | ||
| manifest.package.license_file = locate_file(path, LICENSE_PATHS); | ||
| if package.license_file.is_none() { | ||
| package.license_file = locate_file(path, LICENSE_PATHS); | ||
| } | ||
| manifest.package = Some(package); |
There was a problem hiding this comment.
nit: I would call manifest.package.as_mut to modify the package in-place to prevent cloning and then rewriting the original package. But it doesn't block from merging.
There was a problem hiding this comment.
oooh nice! thanks for the tip, I didn't know about as_mut.
maminrayej
approved these changes
Mar 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in wasmer.toml, the package field will now be optional. This is to add support
for unnamed packages.
Unnamed packages are useful when you don't want to publish and maintain a
package just for an app. In that case, you can simply associate the package with
a webc hash, instead associating it with a package name/version etc.