-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation errors #2281
base: release
Are you sure you want to change the base?
Fix documentation errors #2281
Conversation
Hey @piffio, thanks for the contribution! While this is the mistake, it's unfortunately not the right fix. The files should actually have no extension for both js and ts (like we show in the tutorial). Can you fix this? |
Sure, thanks for the heads up @sodic . I'll take a look at it during the weekend and update the PR! |
Hey @piffio, any updates on this? Do you want me to take it off your hands? |
Hello @sodic , Sorry for being late on this one, but I've been busy building stuff with Wasp :) Thanks for your patience! |
Sure @piffio, thanks! |
Hey @piffio, since we'd like to get this fix out as soon as possible, I was wondering whether you'll have time to finish it this week or should I take over? If you can't spare the time - no problem at all! Don't feel pressured into having to do anything. I just wanted to let you know what's up before I "take away" your contribution :) |
Hey @sodic , thanks for the follow-up. In fact I have switched my focus on other topics lately and I won't likely be back on wasp for a couple of weeks at least. Cheers |
Thanks for the fast reply! No problem, I know how these things go :) Ok then, I'll take it off your hands. |
Description
I was going through the documentation and found some minor issues.
js
files rather thants
ones.Hope this helps
Select what type of change this PR introduces:
Update Waspc ChangeLog and version if needed
If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:
Update example apps if needed
If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:
waspc/examples/todoApp
as needed (updated modified feature or added new feature) and manually checked it works correctly.waspc/headless-test/examples/todoApp
and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).