-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply UnitTestHarness to IonExchange0D #1401
Conversation
@pytest.mark.requires_idaes_solver | ||
@pytest.mark.component | ||
def test_mass_balance(self, IX_lang): | ||
m = IX_lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to keep at least one of these conservation checks in the testing. See #1372 for examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agreed, but wasn't sure how to do so with the test harness without just keeping the existing test, thanks for the direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually conservation checks will work their way into the test harness, but it's not a high priority atm.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
+ Coverage 93.92% 94.02% +0.09%
==========================================
Files 335 335
Lines 35620 35620
==========================================
+ Hits 33456 33491 +35
+ Misses 2164 2129 -35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage and implementation seem fine. I do see you're removing asserting the resulting costing variables because of how the unit model test harness works. The PR for the costing test harness is planned for after the 1.0 overhaul, so you may want to keep the _cost_results
assertions in a test after the normal harness tests just so they're easy to grab in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great idea, just added the costing tests back. |
Fixes/Resolves:
part of #1302
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: