feat: tooltip overlap pdf/text view #533

dorianmiller · 2023-09-25T22:52:48Z

What do these changes do/fix?

Added tooltip for overlapping enrichments.

PDF view

Text view

How do you test/verify these changes?

Open a document in Discovery Tooling.
Select 2 enrichment categories (until overlap is available)
Hover over overlapping enrichments and verify tooltip content

Also, In Components sample app, test contracts visualization. Should be same as before. Some changes in the other views, required fixes in this view:

Have you documented your changes (if necessary)?

NA

Are there any breaking changes included in this pull request?

No

…ight-style

…oltip-pdf

…e-tooltip-pdf

…-tooltip-text

…e-tooltip-pdf

…-tooltip-text

…lap-pdf

CLAassistant · 2023-09-25T22:52:53Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

This reverts commit 4e43f5d.

packages/discovery-react-components/src/components/CIDocument/types.ts

packages/discovery-react-components/src/components/DocumentPreview/types.ts

...eact-components/src/components/CIDocument/components/CIDocumentContent/CIDocumentContent.tsx

packages/discovery-react-components/src/components/CIDocument/types.ts

...s/discovery-react-components/src/components/DocumentPreview/components/HtmlView/HtmlView.tsx

...ery-react-components/src/components/DocumentPreview/components/PdfHighlight/PdfHighlight.tsx

noah-eigenfeld · 2023-10-17T16:00:47Z

Testing results

I keep running into cases where the tooltip isn't displayed all of the enrichments a highlight is associated with, even when the highlight correctly has the overlapping highlights color. At first, I thought it might be that the tooltip needed the two to be an exact match, but then I found examples like this one, where the same word is an exact match for two enrichments, and right next to each other is a highlight with both enrichments in the tooltip and one with a single enrichment.

The above example is a dictionary overlapping with entities v2.

I also keep getting stuck with a ghost highlight/border stuck onscreen, often at different positions.

In addition to these, I see that using the arrows to navigate between highlights only scrolls the highlights into view some of the time in the text view, with no pattern I've found as to the type of enrichment that fails.

Edit: looks like the ghosting highlight is an existing bug. I'll write up a bug report for it.

dorianmiller · 2023-10-17T21:05:00Z

Screenshot 1 and 2: I updated the implementation to match the described design.

jhpedemonte

Works well for me, didn't see any issues in either PDF or Text views. Just had some minor suggestions -- with those fixed, approved.

...ery-react-components/src/components/DocumentPreview/components/PdfHighlight/PdfHighlight.tsx

packages/discovery-react-components/src/components/TooltipHighlight/TooltipHighlight.tsx

jhpedemonte · 2023-10-18T19:37:38Z

packages/discovery-react-components/src/components/TooltipHighlight/TooltipHighlight.tsx

@@ -162,6 +159,28 @@ export function calcToolTipContent(
  return tooltipContent;
 }

+function calcOneTooltipRow(


What exactly does this function do? Please add a comment.

packages/discovery-react-components/src/components/TooltipHighlight/TooltipHighlight.tsx

noah-eigenfeld

Verified that the scrolling issue is fixed now. Code changes look good to me

…lap-pdf

drdorianm added 30 commits June 12, 2023 21:38

feat: text active color and PDF highlight/active colors

c992033

feat: support active and highlight

8246966

Merge remote-tracking branch 'upstream/master' into feat/unique-highl…

562fd17

…ight-style

fix: tweak merge

6359c1f

fix: pr review

39e1bfc

feat: pdf, single tooltip

62fe640

feat: pdf single tooltip

d559c8b

fix: pdf active color, css !important

2eda07b

fix: rename css classes and other pr feedback

dc78541

Merge branch 'feat/unique-highlight-style' into feat/enrich-single-to…

4418d73

…oltip-pdf

fix: single line tooltip

8a48c60

feat: add tooltip for text. Next, update tooltip content

4073543

Merge remote-tracking branch 'upstream/master' into feat/enrich-singl…

c4fcfcc

…e-tooltip-pdf

Merge branch 'feat/enrich-single-tooltip-pdf' into feat/enrich-single…

5d31f00

…-tooltip-text

feat: tooltip for text view

00d0d31

fix: remove debug msg and clean styles

1a1b46b

fix: refactor TooltipHighlight

82df624

Merge remote-tracking branch 'upstream/master' into feat/enrich-singl…

8cd713e

…e-tooltip-pdf

Merge branch 'feat/enrich-single-tooltip-pdf' into feat/enrich-single…

d092c58

…-tooltip-text

fix: do not display empty tooltips or duplicate tooltip content

88d20ea

Merge branch 'feat/enrich-single-tooltip-pdf' into feat/enrich-single…

2a3af59

…-tooltip-text

fix: update text highlight style

149df19

fix: pr feedback

96b251c

fix: tooltip content with table to match design

cca368b

fix: remove sample data for development

89f07d9

Merge branch 'feat/enrich-single-tooltip-pdf' into feat/enrich-single…

ea83b5f

…-tooltip-text

fix: pr feedback

7fb1412

fix: move static text to messages

34fba38

Merge branch 'feat/enrich-single-tooltip-pdf' into feat/enrich-single…

978b6d7

…-tooltip-text

fix: text view, rename TooltipAction to TooltipShow

a9579fc

drdorianm added 7 commits September 5, 2023 13:53

fix: update style for active enrichment in overlap

32b26cf

fix: active enrichment in overlap, show tooltip for overlap

72e1514

feat: track overlap for text view

4bc000b

fix: make a unique ID for text enrichments (work in progress)

46a8e40

feat: unique id for enrichments in text view, remove debug

196753f

Merge remote-tracking branch 'upstream/master' into feat/tooltip-over…

d350807

…lap-pdf

fix: merge

98a5513

dorianmiller requested review from noah-eigenfeld and jhpedemonte as code owners September 25, 2023 22:52

drdorianm added 7 commits September 26, 2023 09:26

fix: unit tests with new enrichment id

99cfbf4

fix: some tests in CIDocument.spec.tsx by adding type

4e43f5d

Revert "fix: some tests in CIDocument.spec.tsx by adding type"

f98c420

This reverts commit 4e43f5d.

fix: getId for Section with and without facets

9b7b608

feat: add const OVERLAP_ID and function initOverlapMeta

bad8d1b

fix: fail gracefully if facetId is invalid

63a0568

fix: align color swatch in tooltip

44867d2

jhpedemonte reviewed Oct 12, 2023

View reviewed changes

drdorianm added 4 commits October 13, 2023 09:58

fix: add comments based on pr feedback (and one rename)

eb3c26c

fix: tweak text z-index for overlap

e08874c

fix: refactor styles for pdf highlight

c3781bb

fix: pr feedback

94b043e

feat: on active enrichment, tooltip displays overlap info

9ceb7dc

jhpedemonte approved these changes Oct 18, 2023

View reviewed changes

fix: pr feedback

572d1cb

noah-eigenfeld approved these changes Nov 7, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/master' into feat/tooltip-over…

04c473f

…lap-pdf

dorianmiller merged commit 0e6d6c5 into watson-developer-cloud:master Nov 8, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: tooltip overlap pdf/text view #533

feat: tooltip overlap pdf/text view #533

dorianmiller commented Sep 25, 2023 •

edited

Loading

CLAassistant commented Sep 25, 2023

noah-eigenfeld commented Oct 17, 2023 •

edited

Loading

dorianmiller commented Oct 17, 2023

jhpedemonte left a comment

jhpedemonte Oct 18, 2023

noah-eigenfeld left a comment

feat: tooltip overlap pdf/text view #533

feat: tooltip overlap pdf/text view #533

Conversation

dorianmiller commented Sep 25, 2023 • edited Loading

What do these changes do/fix?

How do you test/verify these changes?

Have you documented your changes (if necessary)?

Are there any breaking changes included in this pull request?

CLAassistant commented Sep 25, 2023

noah-eigenfeld commented Oct 17, 2023 • edited Loading

Testing results

dorianmiller commented Oct 17, 2023

jhpedemonte left a comment

Choose a reason for hiding this comment

jhpedemonte Oct 18, 2023

Choose a reason for hiding this comment

noah-eigenfeld left a comment

Choose a reason for hiding this comment

dorianmiller commented Sep 25, 2023 •

edited

Loading

noah-eigenfeld commented Oct 17, 2023 •

edited

Loading