Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ibm-watson and other deps #536

Merged
merged 19 commits into from
Jan 23, 2024
Merged

chore: upgrade ibm-watson and other deps #536

merged 19 commits into from
Jan 23, 2024

Conversation

jhpedemonte
Copy link
Member

@jhpedemonte jhpedemonte commented Nov 14, 2023

What do these changes do/fix?

  • Upgrade ibm-watson, which allows us to upgrade axios to pick up vulnerability fixes.
    • BREAKING CHANGE: This upgrade causes types to change and may break consumers.
  • Fixed issue where ibm-watson Disco query API was expecting prop collectionIds but we were passing collection_ids
  • Upgrade to using Node v20
  • Upgrade to yarn v4
  • Use vite to build the components
  • Fix storybook
  • Upgrade a bunch of other dependencies

How do you test/verify these changes?

  • Run storybook
  • Run example app
  • Run tooling with these changes

Have you documented your changes (if necessary)?

Are there any breaking changes included in this pull request?

Yes, the ibm-watson upgrade changes some types, which may cause breaks in consuming code.

@jhpedemonte jhpedemonte changed the title build: vite chore: upgrade ibm-watson and other deps Jan 19, 2024
Copy link
Contributor

@noah-eigenfeld noah-eigenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stuck with storybook for testing, and didn't find any issues

@jhpedemonte jhpedemonte merged commit 97c366f into master Jan 23, 2024
4 checks passed
@jhpedemonte jhpedemonte deleted the build/vite branch January 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants