Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add position: relative to checkboxes, radio buttons, and data table #538

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

jelslip
Copy link
Contributor

@jelslip jelslip commented Jan 23, 2024

to work around Chromium UI issue.

What do these changes do/fix?

https://github.ibm.com/watson-discovery/disco-issue-tracker/issues/17308

Fixes a problem where the UI is shifted upwards after clicking checkboxes or radio buttons in the sample application.

How do you test/verify these changes?

NOTE: You may need to adjust your screen size to see the issue. I see the problem when the browser height is less than about 800 px.

  • In the Discovery Tooling UI, create a Document Retrieval Contracts project.
  • Add the Art Effects.pdf document located at \discovery-components\examples\discovery-search-app\public\documents\Art Effects.pdf. Wait for document processing to complete.
  • Run the sample app in this repository, pointing to the project you created above.
  • In the sample app, open the collection containing the Art Effects.pdf document, then click on the "view passages in document" link displayed in the center pane. The content of the document is then displayed in the center pane with a list of filter radio buttons and checkboxes in the left pane.
  • Click on the Definition radio button in the Nature section of the left pane.

The appropriate text should be selected in the content section, and the UI should not shift upwards.

@jelslip jelslip merged commit 0dca418 into master Jan 23, 2024
4 checks passed
@jelslip jelslip deleted the fix/position-relative_chromium_ui_issue branch January 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants