fix: fixed error in search results due to document title #550
+14
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do/fix?
When using search, regardless of user query (empty or with actual strings), the message
There was an error rendering SearchResults
, when the code doesn't find document title where it is supposed to be. With this fix, it handles the case where title is its own separate field in the document with the format"title": { "a": 1, "text": "title text" }
. If the field title is an object and doesn't have a fieldtext
in string format, just returns thetoString()
so that would result in displaying [object Object]. This would prevent the component from crashing.Github issue: 16447
How do you test/verify these changes?
Improve and Customize
title text
as a part of the resultsHave you documented your changes (if necessary)?
Are there any breaking changes included in this pull request?