chore: bump react peerDep to include react 18 #560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do/fix?
Implementation for https://github.ibm.com/Watson-Discovery/disco-issue-tracker/issues/18222
Bumps the upper limit for react as a peer dependency of the components package. I think this should override the peer dependency in carbon components' 10/7 branch. React 18 shouldn't break anything functionally, but this change allows an app consuming discovery components and using react 18 to build successfully.
How do you test/verify these changes?
yarn
to install the latest package changesyarn why react
and see that the components themselves are still pulling in react 17yarn dlx yalc publish --push
to create a build and push it to a local repository that's linkable in tooling.node_modules
in either the root or components directory and then rerunyarn
yarn dlx yalc add @ibm-watson/discovery-react-components
to link the components build locallyclient/package.json
, changereact
andreact-dom
to "^18.2.0", runyarn
, and then verify withyarn why react
that react 18 is the version being usedyarn run start
andyarn run api:cloud
. Verify that everything builds, and the react components haven't broken (like by running a query and checking the results)Have you documented your changes (if necessary)?
N/A
Are there any breaking changes included in this pull request?
No