Avoid division by 0 to determine minhash_kmer_size
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the estimated identity is 1, we were getting a division by 0, resulting in a
minhash_kmer_sizeequal to 8. While this isn't typically problematic for very highly similar regions, it causes issues inside the human centromeres when aligning their HORs. This leads to increased runtime, high memory usage, and inaccurate alignments.Here is an example of a chr10 alignment with an HG002 assembly vs HG002v1.0.1:
Whole wrong region
Zoom ins
