Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wfmash now builds with clang #304

Merged
merged 21 commits into from
Dec 15, 2024
Merged

wfmash now builds with clang #304

merged 21 commits into from
Dec 15, 2024

Conversation

pjotrp
Copy link
Collaborator

@pjotrp pjotrp commented Dec 14, 2024

Includes a code fix that would not compile on clang with openmp d32f814.

Also guix and cmake fixes and added some tests that are now in github actions(?!):

[100%] Linking CXX executable bin/wfmash
[100%] Built target wfmash
wrk@napoli /export/local/home/wrk/iwrk/opensource/code/pangenome/wfmash/build [env]$ ctest .
Test project /export/local/home/wrk/iwrk/opensource/code/pangenome/wfmash/build
    Start 1: wfmash-time-LPA
1/5 Test #1: wfmash-time-LPA .......................................   Passed   10.27 sec
    Start 2: wfmash-subset-LPA-to-SAM
2/5 Test #2: wfmash-subset-LPA-to-SAM ..............................   Passed   11.89 sec
    Start 3: wfmash-mapping-coverage-with-8-yeast-genomes-to-PAF
3/5 Test #3: wfmash-mapping-coverage-with-8-yeast-genomes-to-PAF ...   Passed   30.20 sec
    Start 4: wfmash-short-reads-500bps-to-SAM
4/5 Test #4: wfmash-short-reads-500bps-to-SAM ......................   Passed   65.74 sec
    Start 5: wfmash-short-reads-255bps-to-PAF
5/5 Test #5: wfmash-short-reads-255bps-to-PAF ......................   Passed    0.91 sec

100% tests passed, 0 tests failed out of 5

1. Renamed BUILD_RETARGETABLE parameter to BUILD_OPTIMIZED
2. LTO support improved
3. Cleaned up switches for optimization
4. Make both dynamic and static builds work
- Honour top level optimization flags
- Support building static and dynamic libs
- Honour building with top level flags
…y much a duplicate of the ones in github actions.
…targets! See the header.

      Also bumped clang to v18.
@AndreaGuarracino AndreaGuarracino merged commit 164433d into waveygang:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants