Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nix flake setup #17

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add a nix flake setup #17

wants to merge 7 commits into from

Conversation

waxlamp
Copy link
Owner

@waxlamp waxlamp commented Mar 15, 2021

No description provided.

@waxlamp waxlamp changed the title Add a flake setup with devShell Add a nix flake setup Apr 12, 2021
flake.nix Outdated
];
};

defaultPackage.x86_64-linux = pkgs.python38Packages.buildPythonPackage rec {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this package only support x86_64-linux? Theres a project called flake-utils you can check out which makes this process easier, so you can go utils.lib.eachDefaultSystem (system: defaultPackage = ...; ) and the outputs get "system spaced".

flake.nix Outdated
let
pkgs = nixpkgs.legacyPackages.x86_64-linux;

leglight = pkgs.python38Packages.buildPythonPackage rec {
Copy link

@Pacman99 Pacman99 Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is opinionated and I have seen other flakes not follow this, but I try not to put too much logic like package creation in the flake.nix. I would put the package in a default.nix and this flake can just call that. I consider flakes more of a place where the sharing aspect comes in and including implementation logic hurts other's ability to see whats happening in your flake. flake.nix to me is a summary of your repo: what it needs, what it exports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants