feat: add subscriber for wayland #86
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
outputsubscription
branch
3 times, most recently
from
08532b4 to
13fe005
Compare
|
Seems the wl_output by other task cannot be used to create new layershell? .. Emm |
Decodetalkers
force-pushed
the
outputsubscription
branch
3 times, most recently
from
b46eb70 to
009f83e
Compare
This pr add a new crate to support listen to the addon of output. and allow new layershell be add to target output
Decodetalkers
force-pushed
the
outputsubscription
branch
from
009f83e to
80f0e61
Compare
id3v1669
reviewed
Nov 25, 2024
| self.last_wloutput.clone() | ||
| } | ||
| events::LayerOutputSetting::ChosenOutput(output) => self | ||
| .xdg_info_cache |
There was a problem hiding this comment.
self.xdg_info_cache in not always populated at this point
Following cycle must be either copied here or moved outside of if is_allscreens statement where it is already present:
for (_, output_display) in &self.outputs {
let zxdgoutput = xdg_output_manager.get_xdg_output(output_display, &qh, ());
self.xdg_info_cache
.push((output_display.clone(), ZxdgOutputInfo::new(zxdgoutput)));
}There was a problem hiding this comment.
self.xdg_info_cachein not always populated at this point Following cycle must be either copied here or moved outside of ifis_allscreensstatement where it is already present:for (_, output_display) in &self.outputs { let zxdgoutput = xdg_output_manager.get_xdg_output(output_display, &qh, ()); self.xdg_info_cache .push((output_display.clone(), ZxdgOutputInfo::new(zxdgoutput))); }
It should has be added at
https://github.com/waycrate/exwlshelleventloop/pull/86/files#diff-d794182b4533a00f543694b67814cc1ffca93afbc14c08c438cb67f8994c821eR2141-R2208
Emm , I do not think add this logic is good..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add a new crate to support listen to the addon of output.
and allow new layershell be add to target output
resolve: #82