[fix] Key release events no longer wrongly swallowed by swhkd #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, key release events for non-modifier keys are swallowed by swhkd. Given a simple modifier+key keybinding (ctrl+p for instance): when first pressing a key (p in this example) without a modifier, a key press event is sent to the virtual device to be consumed by other libraries and applications. Pressing the modifier key afterwards triggers the hotkey as expected. Releasing only the key at this point does not send a key release event to the virtual output, as the event_in_hotkeys boolean is true (control is still being pressed and control + p is mapped to a hotkey after all). To any library afterwards, the key is still being pressed as no release event has been received. To fix this issue, this changes the event_in_hotkey boolean to check for each hotkey if both the event and the hotkey are of the same type. This means that swhkd no longer swallows key press events if a matching hotkey triggers on key release only and it no longer swallows key release events if a matching hotkey triggers on key presses.
|
@ajanon feel free to merge this, patch looks good! |
|
I'm not sure if I'll be merging this one as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, key release events for non-modifier keys are swallowed by swhkd.
Given a simple modifier+key keybinding (ctrl+p for instance): when first pressing a key (p in this example) without a modifier, a key press event is sent to the virtual device to be consumed by other libraries and applications. Pressing the modifier key afterwards triggers the hotkey as expected. Releasing only the key at this point does not send a key release event to the virtual output, as the event_in_hotkeys boolean is true (control is still being pressed and control + p is mapped to a hotkey after all). To any library afterwards, the key is still being pressed as no release event has been received.
To fix this issue, this changes the event_in_hotkey boolean to check for each hotkey if both the event and the hotkey are of the same type. This means that swhkd no longer swallows key press events if a matching hotkey triggers on key release only and it no longer swallows key release events if a matching hotkey triggers on key presses.