Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove manual implementation of fs::read_to_string #238

Merged
merged 1 commit into from
Feb 24, 2024
Merged

refactor: remove manual implementation of fs::read_to_string #238

merged 1 commit into from
Feb 24, 2024

Conversation

lavafroth
Copy link
Contributor

@lavafroth lavafroth commented Feb 24, 2024 •
edited
Loading

Changes

  • Removed load_file_contents which is a manual implementation of fs::read_to_string.
  • Replaced respective occurrences in Config::new and tests.

@Shinyzenith Shinyzenith merged commit 4c4e995 into waycrate:main Feb 24, 2024
7 checks passed
@lavafroth lavafroth deleted the read-to-string branch February 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinyzenith Shinyzenith Shinyzenith approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lavafroth @Shinyzenith