Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] replace manual insertions with collects #241

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[refactor] replace manual insertions with collects #241

merged 1 commit into from
Feb 26, 2024

Conversation

aadilshabier
Copy link
Contributor

@aadilshabier aadilshabier commented Feb 25, 2024 •
edited
Loading

  • This helps remove unnecessary mut's
  • Using static slice prevents the need to create Vec which is discarded anyway
  • Prevent *rc patten from matching src/ directories
  • Propogate errors in uinput::create_uinput_device*() instead of unwrap

@aadilshabier
[refactor] replace manual insertions with collects
6546966 
- This helps remove unnecessary mut's
- Using static slice prevents the need to create Vec which is discarded anyway
- Prevent *rc patten from matching src/ directories
- Propogate errors in uinput::create_uinput_device*() instead of unwrap
@Shinyzenith Shinyzenith merged commit 34b9619 into waycrate:main Feb 26, 2024
7 checks passed
@aadilshabier aadilshabier mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinyzenith Shinyzenith Shinyzenith approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadilshabier @Shinyzenith