Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] environment for swhkd #246

Merged
merged 6 commits into from
Mar 26, 2024
Merged

[refactor] environment for swhkd #246

merged 6 commits into from
Mar 26, 2024

Conversation

newtoallofthis123
Copy link
Contributor

This change introduces similar changes as #243 for swhkd.

The following were the changes made:

  • Added a new environ.rs which is central to the environment management system
  • Refactored env::var uses across the daemon.rs
  • Removed unsafe env uses

Shinyzenith
Shinyzenith requested changes Feb 28, 2024
View reviewed changes
swhkd/src/daemon.rs Outdated Show resolved Hide resolved
@newtoallofthis123 newtoallofthis123 mentioned this pull request Feb 28, 2024
Closed
@Shinyzenith Shinyzenith requested a review from zubairmh February 28, 2024 15:07
@Shinyzenith Shinyzenith added the Enhancement New feature or request label Feb 28, 2024
@Shinyzenith Shinyzenith linked an issue Feb 28, 2024 that may be closed by this pull request
Proposal: Better Path handling Mechanisms #240
Closed
zubairmh
zubairmh approved these changes Feb 28, 2024
View reviewed changes
Copy link

@zubairmh zubairmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. lgtm

@newtoallofthis123
Copy link
Contributor Author

looks good. lgtm

Thanks!

@Shinyzenith
Copy link
Member

Hi, I didn't get a chance to test this pr @zubairmh Did you do so?

aadilshabier
aadilshabier reviewed Mar 5, 2024
View reviewed changes
swhkd/src/environ.rs Outdated Show resolved Hide resolved
@newtoallofthis123
Copy link
Contributor Author

Added some stuff that would enable the environ.rs to check if the path provided is valid or not

@Shinyzenith
Copy link
Member

This looks good to me. I haven't gotten around to testing it yet. @newtoallofthis123 Have you tested the PR?

@newtoallofthis123
Copy link
Contributor Author

I did test it a while ago and everything seemed to work fine 😄

However, I'll test it again tomorrow and let you know just to be safe :)

@Shinyzenith
Copy link
Member

@newtoallofthis123 looks good to go, have you tested this?

@newtoallofthis123
Copy link
Contributor Author

Yep! tested it and it works :)

@Shinyzenith Shinyzenith merged commit 5e8ebe3 into waycrate:main Mar 26, 2024
7 checks passed
InnocentZero added a commit to InnocentZero/swhkd that referenced this pull request Mar 26, 2024
@InnocentZero
[refactor] environment for swhkd (waycrate#246)
ff10fec 
* refactor: New Env for swhkd

* Refactor Functions

* Fix Spelling in environ

* Fix spelling in daemon

* Add Path Validations

* Run formatting

Signed-off-by: innocentzero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aadilshabier aadilshabier aadilshabier left review comments

@zubairmh zubairmh zubairmh approved these changes

@Shinyzenith Shinyzenith Shinyzenith approved these changes

Assignees

@newtoallofthis123 newtoallofthis123

Labels
Enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Better Path handling Mechanisms
4 participants
@newtoallofthis123 @Shinyzenith @aadilshabier @zubairmh