External links opening in a new tab #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shinyzenith could you please review this pr and provide me feedback incase there are any changes to me made? |
uncomfyhalomacro
approved these changes
Aug 12, 2024
Shinyzenith
approved these changes
Aug 12, 2024
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Solving issue #20
External links for GitHub and Discord on the website currently open in the same browser tab, which can disrupt the user experience by navigating away from the site.
Changes Made:
Updated the HTML anchor tags for GitHub and Discord icons to include target="_blank" to ensure that these links open in a new browser tab.
Added rel="noopener noreferrer" to improve security and performance when opening links in a new tab.
Affected Files:
Modified the HTML file containing the links to GitHub and Discord.
Testing:
Clicked on the GitHub icon and verified that it opens in a new tab.
Clicked on the Discord icon and verified that it opens in a new tab.
Additional Notes:
These changes ensure that users can easily return to the website after visiting GitHub or Discord.