chore: reduce repeat code #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decodetalkers
force-pushed
the
lessrepeat
branch
from
06b9b47 to
a5cb923
Compare
Decodetalkers
force-pushed
the
lessrepeat
branch
from
a5cb923 to
eb964fb
Compare
Decodetalkers
force-pushed
the
lessrepeat
branch
from
eb964fb to
ec673e8
Compare
Shinyzenith
requested changes
Oct 8, 2023
|
Apart from that one comment everything else looks fine. I requested it's removal because the context around the call makes it obvious so it's not needed. |
Shinyzenith
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.