Updates to F_Measure #159
Open
Updates to F_Measure #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dush1508
commented
Dec 10, 2024
dush1508
commented
- Added code to ensure that wrong inputs to F_Measure is not accepted
- Upon entering inf, the user is prompted with a "to be added" message
I think some stuff divergered. I am trying to merge it together.
Merged changes from https://github.com/dush1508/SANA into SANA2
Regression_Tests
waynebhayes
requested changes
Dec 10, 2024
There was a problem hiding this comment.
It looks good! However, please put the new testing scripts into a new regression test rather than the main directory of the repo. That means to create a new directory, say regression-tests/f_beta, and put your scripts there. There should also be known correct outputs in the same directory, and the scripts should compare the "live" output to the known good output and report any significant discrepancies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.