-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying the source IP address and/or port #36
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 63.10% 63.13% +0.03%
==========================================
Files 9 9
Lines 580 586 +6
==========================================
+ Hits 366 370 +4
- Misses 214 216 +2
☔ View full report in Codecov by Sentry. |
I'm not sure why one of the checks has failed. If I'm not mistaken, the unit tests themselves passed. |
I'll check it later, thanks for your contribution! 🌹 |
@ECrosland, there is no unittest that checks the behavior when |
Please add unit tests for the new API. |
A
source_address
argument is accepted by thesmtplib.SMTP
andsmtplib.SMTP_SSL
constructors. The argument is a pair comprising an IP address and a port number. Providing this argument is useful when more than one network interface is available to the app, but one in particular must be used when connecting to the SMTP server.I propose to add support for this connection option to Flask-Mailman in the form of two new config properties,
MAIL_SOURCE_ADDRESS
andMAIL_SOURCE_PORT
.Apologies that I have not added mention of this feature to README.md as the contributing guidelines request, but I could not find a section in that file where it seemed to belong. I did add documentation for the two config properties to docs/index.md, however.