feat: news data array adjusted for component loop, and test updated #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breakdancingcat
approved these changes
Jan 6, 2025
nickdenardis
approved these changes
Jan 6, 2025
chrispelzer
approved these changes
Jan 6, 2025
…ors on all styleguides
nickdenardis
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Is this file needed? It isn't referenced anywhere.
|
I think I'm going to have to decline this change, The way the articles data is set up, causes some issues with how the components pull in data vs how the general listing works. |
|
Closing due to many new changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to a walkthru of the issue.
https://www.loom.com/share/43dbbd5850c14a7f954d7bfb2a126d9e?sid=199fbdae-0f53-4e8d-8325-6aec184f9efd
before
After
