Changes in ConfigurationParser module to parse yaml instead of toml #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Nicogp
force-pushed
the
enhancement/103-change-configurationparser-to-parse-yaml
branch
5 times, most recently
from
02b4e8a to
add52fc
Compare
Nicogp
requested review from
jr0me,
sdvendramini,
TomasTurina and
aritosteles
jr0me
approved these changes
Nov 4, 2024
src/agent/configuration_parser/include/configuration_parser.hpp
Outdated
Show resolved
Hide resolved
src/agent/configuration_parser/tests/configuration_parser_test.cpp
Outdated
Show resolved
Hide resolved
src/agent/configuration_parser/tests/configuration_parser_test.cpp
Outdated
Show resolved
Hide resolved
| @@ -37,13 +37,13 @@ void Logcollector::SetupFileReader(const configuration::ConfigurationParser& con | |||
| long reloadInterval = config::DEFAULT_RELOAD_INTERVAL; | |||
|
|
|||
| try { | |||
| fileWait = m_enabled = configurationParser.GetConfig<long>("logcollector", "file_wait"); | |||
| fileWait = configurationParser.GetConfig<long>("logcollector", "file_wait"); | |||
There was a problem hiding this comment.
Nice catch @Nicogp
I'm negatively surprised that this wasn't catch by any warning or static analysis. I played around in godbolt ( https://godbolt.org/z/jb8564oz5 ) and found that there's one warning we should have seen:
[warning: Although the value stored to 'enabled' is used in the enclosing expression, the value is never actually read from 'enabled' [clang-analyzer-deadcode.DeadStores]](javascript:;)
Something to look into later on...
…ion to use yaml instead of toml
Nicogp
force-pushed
the
enhancement/103-change-configurationparser-to-parse-yaml
branch
2 times, most recently
from
5e8089b to
c5dc02a
Compare
Nicogp
force-pushed
the
enhancement/103-change-configurationparser-to-parse-yaml
branch
from
c5dc02a to
104e0b4
Compare
TomasTurina
approved these changes
Nov 4, 2024
TomasTurina
deleted the
enhancement/103-change-configurationparser-to-parse-yaml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changes to the ConfigurationParser module so that it now parses yaml files instead of toml files.
wazuh-agent.ymlTests