Make logs friendlier when agent fails to connect to the manager #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritosteles
requested review from
TomasTurina,
jr0me,
Nicogp and
sdvendramini
aritosteles
force-pushed
the
feat/255-friendly-logs
branch
2 times, most recently
from
65ea228 to
edc5ddd
Compare
TomasTurina
reviewed
Nov 4, 2024
TomasTurina
reviewed
Nov 4, 2024
jr0me
reviewed
Nov 5, 2024
aritosteles
force-pushed
the
feat/255-friendly-logs
branch
from
33a5ce4 to
60c01d4
Compare
aritosteles
changed the title
vikman90
requested changes
Nov 5, 2024
aritosteles
force-pushed
the
feat/255-friendly-logs
branch
3 times, most recently
from
5cce693 to
7fca9e4
Compare
TomasTurina
reviewed
Nov 5, 2024
TomasTurina
reviewed
Nov 5, 2024
TomasTurina
reviewed
Nov 5, 2024
TomasTurina
reviewed
Nov 5, 2024
TomasTurina
reviewed
Nov 5, 2024
TomasTurina
reviewed
Nov 5, 2024
aritosteles
force-pushed
the
feat/255-friendly-logs
branch
3 times, most recently
from
98a8e2d to
c63c2c3
Compare
vikman90
approved these changes
Nov 6, 2024
sdvendramini
approved these changes
Nov 6, 2024
jr0me
approved these changes
Nov 6, 2024
We can override the logger level through environment variable SPDLOG_LEVEL.
These constants should be made configurable settings further ahead.
Adds doxygen style documentation to header file.
aritosteles
force-pushed
the
feat/255-friendly-logs
branch
from
c63c2c3 to
078eee9
Compare
TomasTurina
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make output more friendly when the agent fails to connect to the manager
Tests