Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Object Nesting in Agent Registration #312

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

vikman90
Copy link
Member

@vikman90 vikman90 commented Nov 18, 2024

Related issue
Closes #311

This PR aims to undo object nesting in the agent registration request.

New behavior

Agent registration

{
    "groups": [],
    "host": {
        "architecture": "x86_64",
        "hostname": "Rocket",
        "ip": [
            "172.28.54.98",
            "fe80::215:5dff:feb2:94ca"
        ],
        "os": {
            "name": "Ubuntu",
            "platform": "Linux"
        }
    },
    "id": "7b565a01-8df4-4943-9fb1-6d347ab21853",
    "key": "XTsM35bqCfVGJCBJvvOiButIRMa835Xk",
    "name": "dummy",
    "type": "Endpoint",
    "version": "5.0.0"
}

Unchanged behavior

Stateless message

{"agent":{"groups":[],"host":{"architecture":"x86_64","hostname":"Rocket","ip":["172.28.54.98","fe80::215:5dff:feb2:94ca"],"os":{"name":"Ubuntu","platform":"Linux"}},"id":"7b565a01-8df4-4943-9fb1-6d347ab21853","name":"dummy","type":"Endpoint","version":"5.0.0"}}
{"module":"logcollector","type":"file"}
{"event":{"ingested":"2024-11-18T16:37:43.109Z","module":"logcollector","original":"2024-11-18T17:37:42.822166+01:00 Rocket kernel: docker0: port 1(vethb6c8536) entered disabled state","provider":"syslog"},"log":{"file":{"path":"/var/log/syslog"}},"tags":["mvp"]}

@vikman90 vikman90 linked an issue Nov 18, 2024 that may be closed by this pull request
@vikman90 vikman90 changed the title Fix/311 agent registration object Prevent Object Nesting in Agent Registration Nov 18, 2024
@vikman90 vikman90 self-assigned this Nov 18, 2024
@vikman90 vikman90 added type/bug Bug issue mvp Minimum Viable Product refinement module/agent labels Nov 18, 2024
@vikman90 vikman90 merged commit df31b8d into master Nov 19, 2024
5 checks passed
@vikman90 vikman90 deleted the fix/311-agent-registration-object branch November 19, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/agent mvp Minimum Viable Product refinement type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Object Nesting in Agent Registration
2 participants