Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Logcollector EventChannel Reader for Windows #465

Conversation

LucioDonda
Copy link
Member

@LucioDonda LucioDonda commented Dec 24, 2024

Related issue
Closes #206

Description

This PR solves a section of #201, focuses on implementing the Windows Logcollector module in the Wazuh Agent 5.0.0. The Windows collector will utilize the Event Channel (eventchannel) API to gather system logs, ensuring seamless integration and log management on Windows platforms.

At the end the winevt was finally choose and the bookmarking feature was proposed as a second iteration.

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • Macos

@LucioDonda LucioDonda self-assigned this Dec 24, 2024
@LucioDonda LucioDonda linked an issue Dec 24, 2024 that may be closed by this pull request
10 tasks
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from db0acba to 49a2def Compare January 6, 2025 11:55
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch 5 times, most recently from 3629ae8 to 71eeba5 Compare January 13, 2025 15:28
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch 2 times, most recently from 814c8d0 to 1338171 Compare January 15, 2025 13:57
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch 5 times, most recently from 39da22d to 1d58a78 Compare January 16, 2025 23:19
@LucioDonda LucioDonda force-pushed the feat/206-implement-logcollector-eventchannel-reader-for-windows branch from 1d58a78 to b8b0bae Compare January 16, 2025 23:27
@LucioDonda LucioDonda marked this pull request as ready for review January 17, 2025 12:04
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but LGTM!

Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cborla cborla self-requested a review January 17, 2025 13:23
Copy link
Member

@cborla cborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jr0me jr0me self-requested a review January 17, 2025 14:07
Copy link
Member

@jr0me jr0me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@TomasTurina TomasTurina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TomasTurina TomasTurina merged commit db6679b into master Jan 17, 2025
5 checks passed
@TomasTurina TomasTurina deleted the feat/206-implement-logcollector-eventchannel-reader-for-windows branch January 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Logcollector EventChannel Reader for Windows
6 participants