Custom kitchen-docker gem to correctly remove Docker images #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuasir
suggested changes
Mar 27, 2020
| cd $HOME/wazuh-qa && \ | ||
| git fetch --all && \ | ||
| git checkout devel && \ | ||
| git pull origin devel |
There was a problem hiding this comment.
No need to use pull after fetch --all.
There was a problem hiding this comment.
Hi @manuasir,
I removed git fetch --all so the task to run, now is
RUN cd $HOME && \
git clone https://github.com/wazuh/wazuh-qa.git && \
cd $HOME/wazuh-qa && \
git checkout devel && \
git pull origin develI think pull is needed so it combines the fetch of remote changes and merge them in local, in one command.
Done in 20aa885.
Kr,
Rshad
xr09
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This PR resolves #628.
Kr,
Rshad