Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thomas - Kopi Tracker #154

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Thomas - Kopi Tracker #154

wants to merge 5 commits into from

Conversation

ThomasOh92
Copy link

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 3

How many hours did you spend on this assignment? 2

What part did you spend the most time on? Fixing my migrations

Does the assignment run without errors? If the assignment has errors, what are they? No errors

Describe one part of the code or choose one line you would improve upon. What would you improve? I had to delete some of my old migrations that were saying i hadnt migrated them, even tho i did. I realise its probably cause i accidentally added a blank line in them and saved. Just need to make sure i dont touch old migrations next time.

What did you think of this deliverable? Any other comments? Not bad! Rails generator is the shit

@ThomasOh92
Copy link
Author

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 3

How many hours did you spend on this assignment? 1

What part did you spend the most time on? Figuring out which stuff to hide

Does the assignment run without errors? If the assignment has errors, what are they? No errors

Describe one part of the code or choose one line you would improve upon. What would you improve? probably add some messages in the UI, telling people whether they are normal users or admins

What did you think of this deliverable? Any other comments? Good practice with devise!

@ThomasOh92
Copy link
Author

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 3

How many hours did you spend on this assignment? 1

What part did you spend the most time on? Figuring out the right commands for generating scaffold, adding devise to existing model

Does the assignment run without errors? If the assignment has errors, what are they? No errors

Describe one part of the code or choose one line you would improve upon. What would you improve? probably test out the authentication for customers abit more. I know it works, but some UI demonstration of it would be good.

What did you think of this deliverable? Any other comments? Learned how to add devise to existing model!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant