Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image-tag: Rework the -WIP logic #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlespiau
Copy link
Contributor

@dlespiau dlespiau commented Nov 16, 2017

Seems like grepping the output of git status --porcelain broke. Use a
different approach with git diff and only check the events we care about
(having staged and un staged changes).

@dlespiau dlespiau requested a review from bboreham November 16, 2017 17:32
Seems like grepping the output of git status --porcelain broken. Use a
different approach with git diff and only checks the events we care about
(having staged and un staged changes).
@dlespiau dlespiau force-pushed the 2017-11-16-fix-image-tag branch from 9eac7a0 to 2838263 Compare November 16, 2017 17:52
@leth
Copy link
Contributor

leth commented Dec 14, 2017

IIRC the reason I changed this was to avoid git reading all the files to generate a diff, which can be slow over a mounted filesystem.

@bboreham
Copy link
Contributor

bboreham commented Dec 14, 2017

@leth would you care to explain your regex? ISTM that a regex approach should work, but I had git status --porcelain like this:

 M src/kubernetes.js
 M src/server.js
 M tools/image-tag
?? src/oneweave.js
?? src/oneweave.js~

and it decided that meant there was no WIP.

@leth
Copy link
Contributor

leth commented Dec 14, 2017

I tested it with that output, and it correctly said -WIP for me, so I'm not sure what is broken.
I think i've overcomplicated the regex though: grep -qE '^[^ ][^ ]\s' would suffice.

@bboreham
Copy link
Contributor

what is happening with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants