add tests

weaveworks · Sep 14, 2022 · 429dc7b · 429dc7b
1 parent 4c62e03
commit 429dc7b
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 16 deletions.
diff --git a/ui/components/AlertsTable.tsx b/ui/components/AlertsTable.tsx
@@ -66,22 +66,19 @@ function AlertsTable({ className, rows = [] }: Props) {
         return (
           <ul className="event-sources">
             {a?.eventSources?.map((obj: CrossNamespaceObjectRef, index) => {
-              if (obj.name && obj.namespace && obj.kind)
-                return (
-                  <Link
-                    className="event-sources"
-                    key={index}
-                    to={makeEventSourceLink(obj)}
-                  >
-                    {obj.kind}: {obj.namespace}/{obj.name}
-                  </Link>
-                );
-              else
-                return (
-                  <li className="event-sources" key={index}>
-                    {obj.kind}: {obj.namespace}/{obj.name}
-                  </li>
-                );
+              obj.name && obj.namespace && obj.kind ? (
+                <Link
+                  className="event-sources"
+                  key={index}
+                  to={makeEventSourceLink(obj)}
+                >
+                  {obj.kind}: {obj.namespace}/{obj.name}
+                </Link>
+              ) : (
+                <li className="event-sources" key={index}>
+                  {obj.kind}: {obj.namespace}/{obj.name}
+                </li>
+              );
             })}
           </ul>
         );

diff --git a/ui/components/__tests__/AlertsTable.test.tsx b/ui/components/__tests__/AlertsTable.test.tsx
@@ -0,0 +1,35 @@
+import { makeEventSourceLink } from "../AlertsTable";
+
+describe("AlertsTable", () => {
+  describe("makeEventSourceLink", () => {
+    it("should convert CrossNamespaceRef objects to urls with filters", () => {
+      const allNames = {
+        apiVersion: "v1",
+        name: "*",
+        namespace: "space",
+        kind: "GitRepository",
+        matchLabels: [],
+      };
+      const sourceLink = makeEventSourceLink(allNames);
+      expect(sourceLink.includes("/sources")).toEqual(true);
+      expect(
+        sourceLink.includes("type") && sourceLink.includes("GitRepository")
+      ).toEqual(true);
+      console.log(sourceLink);
+      expect(sourceLink.includes("*")).toEqual(false);
+      const allNamespaces = {
+        apiVersion: "v1",
+        name: "goose",
+        namespace: "*",
+        kind: "HelmRelease",
+        matchLabels: [],
+      };
+      const automationLink = makeEventSourceLink(allNamespaces);
+      expect(automationLink.includes("/applications")).toEqual(true);
+      expect(
+        automationLink.includes("name") && automationLink.includes("goose")
+      ).toEqual(true);
+      expect(automationLink.includes("namespace")).toEqual(false);
+    });
+  });
+});