small optimization in makeEventSourceLink

weaveworks · Sep 14, 2022 · de20f11 · de20f11
1 parent 70a9cc2
commit de20f11
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/ui/components/AlertsTable.tsx b/ui/components/AlertsTable.tsx
@@ -23,13 +23,11 @@ export const makeEventSourceLink = (obj: CrossNamespaceObjectRef) => {
     obj.kind === Kind.Kustomization || obj.kind === Kind.HelmRelease
       ? V2Routes.Automations
       : V2Routes.Sources;
-  let filters = "";
+  let filters = `type${filterSeparator}${obj.kind}_`;
   if (obj.name !== "*") filters += `name${filterSeparator}${obj.name}_`;
   if (obj.namespace !== "*")
     filters += `namespace${filterSeparator}${obj.namespace}_`;
-  filters += `type${filterSeparator}${obj.kind}_`;
-  if (filters) return url + `?${qs.stringify({ filters: filters })}`;
-  return url;
+  return url + `?${qs.stringify({ filters: filters })}`;
 };
 
 function AlertsTable({ className, rows = [] }: Props) {