Skip to content

fix: revert breaking change and add deprecation notices #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2025

Conversation

bevzzz
Copy link
Collaborator

@bevzzz bevzzz commented Apr 9, 2025

Follow-up for #278

Unfortunately, the initial PR adding dynamic user management had a couple of blunders, which I'm addressing in this PR.

  • ‼️ Bring back roles.assignedUserIds -- I'd got a false impression that this method was removed in the Python client and replaced it with userAssignments rather than deprecating it.
  • Return false on HTTP 409 Conflict from /activate and /deactivate endpoints.
  • Add deprecation notices to users.assignRoles, users.revokeRoles, and roles.assignedUserIds

@bevzzz bevzzz requested a review from a team as a code owner April 9, 2025 11:21
@bevzzz bevzzz requested review from dirkkul and tsmith023 April 9, 2025 11:21
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@bevzzz bevzzz merged commit f7450c9 into main Apr 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants