Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend of aggregate API to use gRPC #1522

Merged
merged 14 commits into from
Feb 3, 2025

Conversation

tsmith023
Copy link
Collaborator

No description provided.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 changed the title Add initial support for gRPC aggregate method for use in __len__ Refactor backend of aggregate API to use gRPC Jan 30, 2025
@tsmith023 tsmith023 marked this pull request as ready for review January 30, 2025 17:00
@tsmith023 tsmith023 requested a review from a team as a code owner January 30, 2025 17:00
weaviate/collections/classes/aggregate.py Show resolved Hide resolved
weaviate/collections/classes/aggregate.py Outdated Show resolved Hide resolved
weaviate/collections/collection/async_.py Outdated Show resolved Hide resolved
weaviate/collections/collection/sync.py Outdated Show resolved Hide resolved
weaviate/collections/aggregations/over_all.py Outdated Show resolved Hide resolved
weaviate/collections/aggregations/aggregate.py Outdated Show resolved Hide resolved
weaviate/collections/aggregations/aggregate.py Outdated Show resolved Hide resolved
weaviate/collections/aggregations/aggregate.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.69351% with 131 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev/1.29@e414c99). Learn more about missing BASE report.

Files with missing lines Patch % Lines
weaviate/collections/grpc/shared.py 70.71% 53 Missing ⚠️
weaviate/collections/aggregations/aggregate.py 55.55% 24 Missing ⚠️
weaviate/collections/grpc/aggregate.py 80.00% 12 Missing ⚠️
weaviate/collections/aggregations/near_vector.py 47.61% 11 Missing ⚠️
weaviate/collections/classes/aggregate.py 76.47% 8 Missing ⚠️
weaviate/collections/aggregations/hybrid.py 54.54% 5 Missing ⚠️
weaviate/collections/aggregations/near_image.py 58.33% 5 Missing ⚠️
integration/test_collection_aggregate.py 75.00% 4 Missing ⚠️
weaviate/collections/aggregations/near_object.py 72.72% 3 Missing ⚠️
weaviate/collections/aggregations/near_text.py 72.72% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.29    #1522   +/-   ##
===========================================
  Coverage            ?   88.22%           
===========================================
  Files               ?      182           
  Lines               ?    15653           
  Branches            ?        0           
===========================================
  Hits                ?    13810           
  Misses              ?     1843           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit efeda9c into dev/1.29 Feb 3, 2025
41 of 42 checks passed
@tsmith023 tsmith023 deleted the grpc/add-initial-support-for-aggregate branch February 3, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants