Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope to role permission #1528

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Add scope to role permission #1528

merged 3 commits into from
Feb 4, 2025

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Jan 29, 2025

No description provided.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@dirkkul dirkkul requested a review from a team as a code owner February 3, 2025 14:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (92588ed) to head (582d6ce).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_rbac.py 46.15% 7 Missing ⚠️
weaviate/rbac/models.py 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1528      +/-   ##
==========================================
- Coverage   90.12%   88.95%   -1.17%     
==========================================
  Files         175      182       +7     
  Lines       15055    15335     +280     
==========================================
+ Hits        13568    13642      +74     
- Misses       1487     1693     +206     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weaviate/classes/rbac.py Show resolved Hide resolved
@dirkkul dirkkul merged commit 5ac82d8 into main Feb 4, 2025
39 checks passed
@dirkkul dirkkul deleted the manage_scope branch February 4, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants