-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NormalModuleFactory and resolveForScheme hook #2356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
589cde2
to
8631950
Compare
🦋 Changeset detectedLatest commit: 4660372 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b3ef262
to
1bf325a
Compare
7 tasks
1bf325a
to
c89dbbd
Compare
already tested by #2152 (comment) |
ahabhgk
previously approved these changes
Mar 21, 2023
h-a-n-a
reviewed
Mar 21, 2023
h-a-n-a
previously approved these changes
Mar 21, 2023
h-a-n-a
approved these changes
Mar 21, 2023
we need take benchmark back before merge this MR |
!bench |
ahabhgk
approved these changes
Mar 21, 2023
Benchmark Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NMF.hooks.resolveForScheme
except for the second param, because our data structure is not aligned to webpack https://github.com/webpack/webpack/blob/main/lib/NormalModuleFactory.js#L50-L64, but it is enough for angular usage.Related issue (if exists)
NormalModuleFactory
parameter inthisCompilation
hook. #2377resolveForScheme
hook ofNormalModuleFactory
#2375Types of changes
Checklist
pnpm run changeset
.