Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tree shaking size differentiation between webpack #5349

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: tree shaking size differentiation between webpack #5349

merged 1 commit into from
Jan 17, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jan 16, 2024 •
edited
Loading

Summary

  1. Part of Improve bundle size after tree shaking #5317

Test Plan

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 16, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title feat: 🎸 init fix: tree shaking size Jan 16, 2024
@IWANABETHATGUY
Copy link
Contributor Author

!canary

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) and removed release: feature release: feature related release(mr only) labels Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

0.5.0-canary-f37d888-20240116115414

@IWANABETHATGUY
Copy link
Contributor Author

!diff

@github-actions GitHub Actions
Copy link
Contributor

arco-pro

Runtime Modules Rspack Only Common Webpack Only Common Percent
Modules 1 12 0 92.31%
Lines 28 179 0 86.47%
Lines(Common Modules) 0 179 0 100.00%
Normal Modules Rspack Only Common Webpack Only Common Percent
Modules 434 898 0 67.42%
Lines 64302 96916 28432 51.10%
Lines(Common Modules) 23943 96916 28432 64.92%

View diff report

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 17, 2024 03:19
@IWANABETHATGUY IWANABETHATGUY requested review from a team, jerrykingxyz and ahabhgk January 17, 2024 03:19
@IWANABETHATGUY IWANABETHATGUY changed the title fix: tree shaking size fix: tree shaking differentiation between webpack Jan 17, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title fix: tree shaking differentiation between webpack fix: tree shaking size differentiation between webpack Jan 17, 2024
@IWANABETHATGUY IWANABETHATGUY merged commit 2a633e2 into main Jan 17, 2024
29 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the fix/tree-shaking-size2 branch January 17, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @ahabhgk