Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable parallel code splitting #9059

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

JSerFeng
Copy link
Contributor

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@JSerFeng
Copy link
Contributor Author

!bench

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 21, 2025
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit a4613bf
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6795e0976b0d74000811776d
😎 Deploy Preview https://deploy-preview-9059--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #9059 will not alter performance

Comparing feat/new-code-splitting (a4613bf) with main (5c79dcf)

Summary

✅ 4 untouched benchmarks

@JSerFeng JSerFeng force-pushed the feat/new-code-splitting branch from 1b6def5 to a4613bf Compare January 21, 2025 10:05
@JSerFeng
Copy link
Contributor Author

Because of removeAvailableModules is false by default, new code splitting won't remove, so there are many dup modules in the end, costs much time in emitFile

Copy link
Contributor

github-actions bot commented Jan 26, 2025

📝 Benchmark detail: Open

Name Base (2025-01-26 f6401df) Current Change
10000_big_production-mode_disable-minimize + exec 37.6 s ± 670 ms 38.9 s ± 1.23 s +3.48 %
10000_development-mode + exec 1.82 s ± 29 ms 1.83 s ± 46 ms +0.64 %
10000_development-mode_hmr + exec 683 ms ± 5.7 ms 680 ms ± 26 ms -0.49 %
10000_production-mode + exec 2.4 s ± 65 ms 2.41 s ± 103 ms +0.42 %
10000_production-mode_persistent-cold + exec 2.61 s ± 135 ms 2.53 s ± 34 ms -3.19 %
10000_production-mode_persistent-hot + exec 1.75 s ± 40 ms 1.74 s ± 35 ms -0.89 %
arco-pro_development-mode + exec 1.74 s ± 120 ms 1.76 s ± 117 ms +1.39 %
arco-pro_development-mode_hmr + exec 388 ms ± 1.9 ms 387 ms ± 5.4 ms -0.04 %
arco-pro_production-mode + exec 3.72 s ± 170 ms 3.77 s ± 184 ms +1.37 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.86 s ± 246 ms 3.8 s ± 102 ms -1.67 %
arco-pro_production-mode_persistent-cold + exec 3.92 s ± 136 ms 3.97 s ± 191 ms +1.44 %
arco-pro_production-mode_persistent-hot + exec 2.49 s ± 117 ms 2.58 s ± 264 ms +3.62 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.78 s ± 55 ms 3.79 s ± 228 ms +0.22 %
large-dyn-imports_development-mode + exec 2.08 s ± 35 ms 2.08 s ± 61 ms -0.14 %
large-dyn-imports_production-mode + exec 2.15 s ± 34 ms 2.17 s ± 36 ms +0.82 %
threejs_development-mode_10x + exec 1.54 s ± 20 ms 1.53 s ± 25 ms -0.57 %
threejs_development-mode_10x_hmr + exec 782 ms ± 28 ms 777 ms ± 12 ms -0.68 %
threejs_production-mode_10x + exec 5.41 s ± 116 ms 5.43 s ± 223 ms +0.34 %
threejs_production-mode_10x_persistent-cold + exec 5.53 s ± 178 ms 5.56 s ± 323 ms +0.53 %
threejs_production-mode_10x_persistent-hot + exec 4.75 s ± 135 ms 4.75 s ± 390 ms +0.14 %
10000_big_production-mode_disable-minimize + rss memory 8715 MiB ± 76.3 MiB 8697 MiB ± 53.8 MiB -0.20 %
10000_development-mode + rss memory 639 MiB ± 17.5 MiB 646 MiB ± 11.6 MiB +1.16 %
10000_development-mode_hmr + rss memory 1249 MiB ± 202 MiB 1320 MiB ± 138 MiB +5.68 %
10000_production-mode + rss memory 632 MiB ± 22.6 MiB 634 MiB ± 24 MiB +0.31 %
10000_production-mode_persistent-cold + rss memory 748 MiB ± 38.6 MiB 744 MiB ± 24.4 MiB -0.59 %
10000_production-mode_persistent-hot + rss memory 725 MiB ± 12.5 MiB 719 MiB ± 16.2 MiB -0.80 %
arco-pro_development-mode + rss memory 556 MiB ± 33.9 MiB 555 MiB ± 24.6 MiB -0.15 %
arco-pro_development-mode_hmr + rss memory 643 MiB ± 65.9 MiB 660 MiB ± 50.9 MiB +2.57 %
arco-pro_production-mode + rss memory 718 MiB ± 26.6 MiB 716 MiB ± 42.5 MiB -0.30 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 723 MiB ± 47 MiB 730 MiB ± 22.1 MiB +0.94 %
arco-pro_production-mode_persistent-cold + rss memory 855 MiB ± 32.2 MiB 852 MiB ± 20.1 MiB -0.42 %
arco-pro_production-mode_persistent-hot + rss memory 713 MiB ± 21.8 MiB 708 MiB ± 20.5 MiB -0.66 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 720 MiB ± 46.1 MiB 714 MiB ± 31.3 MiB -0.88 %
large-dyn-imports_development-mode + rss memory 645 MiB ± 7.9 MiB 643 MiB ± 5.48 MiB -0.35 %
large-dyn-imports_production-mode + rss memory 525 MiB ± 3.31 MiB 530 MiB ± 3.41 MiB +0.80 %
threejs_development-mode_10x + rss memory 545 MiB ± 15.7 MiB 551 MiB ± 5.89 MiB +1.21 %
threejs_development-mode_10x_hmr + rss memory 1140 MiB ± 135 MiB 1124 MiB ± 81.2 MiB -1.43 %
threejs_production-mode_10x + rss memory 824 MiB ± 44.9 MiB 840 MiB ± 42.9 MiB +1.94 %
threejs_production-mode_10x_persistent-cold + rss memory 953 MiB ± 84.1 MiB 929 MiB ± 40.5 MiB -2.50 %
threejs_production-mode_10x_persistent-hot + rss memory 885 MiB ± 34.3 MiB 847 MiB ± 52.8 MiB -4.27 %

@web-infra-dev web-infra-dev deleted a comment from github-actions bot Jan 26, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot Jan 26, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot Jan 26, 2025
@web-infra-dev web-infra-dev deleted a comment from github-actions bot Jan 26, 2025
@JSerFeng JSerFeng force-pushed the feat/new-code-splitting branch from d6bebab to a4613bf Compare January 26, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant